Skip to content

Resolve pending render entities by main entity - #25816

Open
stuartparmenter wants to merge 1 commit into
bevyengine:mainfrom
stuartparmenter:fix/resolve-pending-render-entities
Open

stuartparmenter wants to merge 1 commit into
bevyengine:mainfrom
stuartparmenter:fix/resolve-pending-render-entities

Conversation

@stuartparmenter

@stuartparmenter stuartparmenter commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Objective

Fix meshes losing pending specialization when their render entity changes while they remain visible, such as when adding a component that requires SyncToRenderWorld.

Solution

Resolve pending entries by main entity in both specialization and queueing, using the current visible render entity. This also skips pending entities that are no longer visible and preserves queue deduplication.

Testing

Checked the iterator logic in an isolated Rust harness: stale render IDs and invisible pending entries fail before the fix and pass afterward. Queue deduplication and GPU-visible retries still pass. Formatting checks passed.


This was AI assisted w/ Fable when tracking down a bug in my game. Looked at storing only main entities in the pending queues, but that would be a larger refactor, so went with the focused fix.

@stuartparmenter stuartparmenter added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 16, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Sep 16, 2026
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples X-Uncontroversial This work is generally agreed upon and removed D-Trivial Nice and easy! A great choice to get started with Bevy labels Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

2 participants