Skip to content

Retry mesh specialization when RenderMesh is not ready - #25815

Merged
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
stuartparmenter:fix/retry-unprepared-render-mesh
Oct 5, 2026
Merged

alice-i-cecile merged 2 commits into
bevyengine:mainfrom
stuartparmenter:fix/retry-unprepared-render-mesh

Conversation

@stuartparmenter

@stuartparmenter stuartparmenter commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Objective

Fix meshes remaining invisible when specialization runs before their RenderMesh is ready.

Solution

Re-enqueue specialization when the mesh is unavailable in the material, prepass, shadow, 2D material, and 3D wireframe paths. This feels like the most straight forward fix w/o a larger refactor.

Testing

Tested in my game where the issue was hit


This was AI assisted w/ Fable when tracking down a bug in my game -- applied the fix to all the places where it needs to be. Looked at how to avoid so much boilerplate, but all the other solutions were signifigantly larger refactors, so went with the easiest solution.

@stuartparmenter stuartparmenter added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 16, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Sep 16, 2026
@JMS55
JMS55 requested a review from kfc35 September 25, 2026 22:41
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 30, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Oct 5, 2026
Merged via the queue into bevyengine:main with commit ec535d7 Oct 5, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants