Skip to content

Fix feathers_gallery Okhsl swatch having inverted y movement - #25813

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
dylansechet:feathers_gallery_fix
Sep 20, 2026
Merged

Fix feathers_gallery Okhsl swatch having inverted y movement#25813
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
dylansechet:feathers_gallery_fix

Conversation

@dylansechet

@dylansechet dylansechet commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Objective

If you open the feathers_gallery example and move your mouse on the Okhsl swatch, y movement is inverted.

Solution

Somehow a 1.0 - made its way into #25626. Revert it.

Testing

  • Ran feathers_gallery

@dylansechet dylansechet changed the title Fix feathers_gallery Okhsl swatch having inverted y movement Fix feathers_gallery Okhsl swatch having inverted y movement Sep 16, 2026
ickshonpe
ickshonpe approved these changes Sep 16, 2026
View reviewed changes

@ickshonpe ickshonpe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ickshonpe ickshonpe added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 16, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Sep 16, 2026
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 19, 2026
@tmstorey tmstorey mentioned this pull request Sep 20, 2026
Closed
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Sep 20, 2026
Merged via the queue into bevyengine:main with commit 2917e2f Sep 20, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Sep 20, 2026
gregcsokas pushed a commit to gregcsokas/bevy that referenced this pull request Sep 21, 2026
@dylansechet @gregcsokas
Fix feathers_gallery Okhsl swatch having inverted y movement (bevye…
0fcfdb1 
…ngine#25813)

# Objective

If you open the `feathers_gallery` example and move your mouse on the
Okhsl swatch, y movement is inverted.

## Solution

Somehow a `1.0 - ` made its way into bevyengine#25626. Revert it.

## Testing

- Ran `feathers_gallery`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Zeophlite Zeophlite Zeophlite approved these changes
@tmstorey tmstorey tmstorey approved these changes
@ickshonpe ickshonpe ickshonpe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

UI
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dylansechet @Zeophlite @tmstorey @ickshonpe @alice-i-cecile