Skip to content

ci(publish): only master publishes - #43

Merged
cbetta merged 1 commit into
masterfrom
publish-main-only
Oct 24, 2026
Merged

cbetta merged 1 commit into
masterfrom
publish-main-only

Conversation

@cbetta

@cbetta cbetta commented Oct 24, 2026 •

Copy link
Copy Markdown
Member
Reviewer check This PR
Auth / permissions No
Data access widened No
New secret, env var or key No
CI, deploy or infra Yes: .github/workflows/publish.yml
Dependencies added or bumped No
Copilot Clean: no findings
Security review Not run (two-line CI guard)

A manual workflow_dispatch run on a branch pushed that branch as :master, which jiji then deploys; now only master publishes.

  publish:
    needs: ci
    # A manual run can pick any branch; only master ever becomes :master.
    if: github.ref == 'refs/heads/master'

🤖 Generated with Claude Code

A manual run of publish.yml on another branch pushed that branch as :master, which jiji's pin timer then deploys. The publish job now runs only for refs/heads/master.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The condition blocks non-master publishing while preserving the existing CI gate and publishing permissions.

No open issues 🎉

What changed in this PR

Restricts image publishing to master, preventing manual runs on other branches from publishing an image tagged :master for deployment.

Changes:

  • Adds a job-level branch condition while preserving the existing CI dependency.
  • Documents why manual runs need this restriction.
File Description
.github/​workflows/​publish.yml Allows the publish job to run only for refs/heads/master.

Review effort: Balanced

@cbetta
cbetta marked this pull request as ready for review October 24, 2026 12:14
@cbetta
cbetta merged commit 9987173 into master Oct 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants