Epic/rordev 1524 keep ror kibana and es plugins configuration in a single file - #116
Open
Dzuming wants to merge 19 commits into
Open
Conversation
- Switch ROR configuration to use the Kibana API instead of the ES API - Add new fixture files for default settings - Add helper functions to merge and parse YAML settings in Cypress tests - Update Settings page object with support for dynamic ROR settings setup
Chromium 138 (bundled with Cypress 15) requires user activation for
clipboard access, breaking existing copy-based tests. This change adds
a capture utility that intercepts `navigator.clipboard.writeText` and
`document.execCommand('copy')` to track copied content within the
browser context, bypassing OS-level clipboard requirements.
Implements `fetchWithJsonRetry` to handle Kibana startup race conditions where requests are served a login page instead of the expected JSON response. This ensures that FormData streams are correctly recreated across retry attempts.
Handle 403 errors during saved object cleanup when indices are resetting. Update return types and status polling methods for better Cypress chain compatibility.
- Replace `cy.wait` with `cy.waitForResponse` for better reliability. - Increase timeout for dashboard element lookup to 20 seconds.
- Standardize Kibana SSL/TLS settings across all fixtures - Remove unused ECK-related environment placeholders - Clean up ReadonlyREST and Kibana configuration structure
- Externalize Kibana settings configuration to a central constant. - Add `waitForIndexReady` helper to handle lazy index provisioning. - Standardize settings reset flows between test cases to prevent state leakage. - Update `getSavedObjects` calls to handle expected 404/403 status codes.
Replace the legacy `ror-config.cy.ts` file with a comprehensive `Readonlyrest-settings.cy.ts` suite to verify ReadonlyREST Kibana configuration features.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `kibanaIndexTemplate` test is skipped in the `elk-ror` environment to avoid race conditions with Kibana replica round-robin behavior. Additionally, updated the uncaught exception suppression to globally handle chunk loading errors across Kibana versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.