You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! I know I recommended the Render.call() thing initially, but we've since discovered that you can just import a native class that extends Component and render that, which feels much more React-y, and allows the native subclass to override any method of Component (such as storing its own state if it wants to) rather than just Render().
Here's a PR that shows how that works. It's totally untested, though, please test carefully if you decide you'd like to merge! No worries if you decide you prefer the old method. I just thought I'd share.
I am not going to merge it for 2 reasons (at least now).
First even if more "react-y" I think it makes the code harder to get for people who are not so used to react and the goal of the repo was more to demonstrate how to use react to make the 3 apps rather than having a high technical demo of React, and second I think it would be nice to have the android app merged and structured with a more classical way of doing javascript first.
About the tests, they all passed and the react-native build too so I think your version works great.
About merging, we will see in the future because this approach is so interesting and I think may also help to get a simpler structure when the android version will be merged because thinking in terms of components imbrication may be easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I know I recommended the Render.call() thing initially, but we've since discovered that you can just import a native class that extends Component and render that, which feels much more React-y, and allows the native subclass to override any method of Component (such as storing its own state if it wants to) rather than just Render().
Here's a PR that shows how that works. It's totally untested, though, please test carefully if you decide you'd like to merge! No worries if you decide you prefer the old method. I just thought I'd share.