Skip to content

Remove the on demand database backup and database.data_store - #1041

Merged
epompeii merged 1 commit into
u/ep/s3-r2/disaster-recoveryfrom
u/ep/s3-r2/server-backup
Oct 4, 2026
Merged

epompeii merged 1 commit into
u/ep/s3-r2/disaster-recoveryfrom
u/ep/s3-r2/server-backup

Conversation

@epompeii

@epompeii epompeii commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

The on demand database backup predates continuous replication and is unused. Its config section, database.data_store, took an AWS S3 access point ARN and was the only reason bencher_schema depended on the AWS SDK. Continuous replication under plus.disaster_recovery is the supported path.

Changes

  • POST /v0/server/backup and its OPTIONS handler are removed, and the OpenAPI spec is regenerated.
  • bencher server backup is removed from the CLI.
  • database.data_store and its types are removed from the server config; bencher_schema drops aws-sdk-s3 and aws-credential-types, and the root manifest drops async-compression and rusqlite, which had no user left. camino becomes a plus dependency of bencher_schema, its only remaining user being plus-gated, and tokio's fs feature goes with the last tokio::fs call.
  • The manual backup workflow is deleted.
  • Docs in all 9 languages lose the Backups section and its CLI chunks; the database config reference and the shared example lose data_store; the disaster recovery pages no longer refer to backups, and the self-hosted skill links disaster recovery to its explanation page.
  • A test pins that a database section still carrying data_store deserializes with its other fields intact, so a stale config never fails to boot.

Breaking changes

  • POST /v0/server/backup and bencher server backup are gone.
  • A config that still carries database.data_store is ignored. Remove the section.

Second of a stack of three, on top of the plus.disaster_recovery rename. The last PR moves the container registry storage onto object_store, at which point the AWS SDK leaves the workspace.

@epompeii
epompeii added this pull request to stack #1042 September 18, 2026 06:48
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

馃惏 Bencher Report

ProjectBencher
Branchu/ep/s3-r2/server-backup
Testbedintel-v1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (碌s)
(Result 螖%)
Upper Boundary
microseconds (碌s)
(Limit %)
Adapter::Json馃搱 view plot
馃毞 view threshold
5.33 碌s
(+5.48%)Baseline: 5.05 碌s
6.16 碌s
(86.49%)
Adapter::Magic (JSON)馃搱 view plot
馃毞 view threshold
5.15 碌s
(+5.52%)Baseline: 4.88 碌s
5.83 碌s
(88.23%)
Adapter::Magic (Rust)馃搱 view plot
馃毞 view threshold
26.74 碌s
(-0.79%)Baseline: 26.95 碌s
30.12 碌s
(88.77%)
Adapter::Rust馃搱 view plot
馃毞 view threshold
4.67 碌s
(+7.66%)Baseline: 4.33 碌s
6.65 碌s
(70.19%)
Adapter::RustBench馃搱 view plot
馃毞 view threshold
4.66 碌s
(+7.58%)Baseline: 4.33 碌s
6.64 碌s
(70.12%)
馃惏 View full continuous benchmarking report in Bencher

@epompeii
epompeii marked this pull request as ready for review September 18, 2026 07:47
@epompeii
epompeii marked this pull request as draft October 1, 2026 02:26
@epompeii
epompeii force-pushed the u/ep/s3-r2/server-backup branch from 3f36999 to 9a8fed7 Compare October 1, 2026 05:43
@epompeii
epompeii marked this pull request as ready for review October 1, 2026 06:14
The POST /v0/server/backup endpoint, the bencher server backup CLI
subcommand, and the database.data_store server config section are gone.
Continuous replication under plus.disaster_recovery is the supported
path, so bencher_schema no longer depends on the AWS SDK.
A config that still carries database.data_store is ignored.
@epompeii
epompeii marked this pull request as draft October 3, 2026 19:02
@epompeii
epompeii force-pushed the u/ep/s3-r2/server-backup branch from 9a8fed7 to ec13c3d Compare October 3, 2026 19:34
@epompeii
epompeii marked this pull request as ready for review October 4, 2026 16:44
@epompeii
epompeii merged commit 84d1578 into devel Oct 4, 2026
64 checks passed
@epompeii
epompeii deleted the u/ep/s3-r2/server-backup branch October 4, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant