Repository navigation
Make plus.disaster_recovery the only key and drop sftp - #1040
Merged
Merged
Conversation
Contributor
|
| Project | Bencher |
| Branch | u/ep/s3-r2/disaster-recovery |
| Testbed | intel-v1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (碌s) (Result 螖%) | Upper Boundary microseconds (碌s) (Limit %) |
|---|---|---|---|
| Adapter::Json | 馃搱 view plot 馃毞 view threshold | 5.34 碌s(+5.85%)Baseline: 5.04 碌s | 6.15 碌s (86.86%) |
| Adapter::Magic (JSON) | 馃搱 view plot 馃毞 view threshold | 5.14 碌s(+5.63%)Baseline: 4.87 碌s | 5.82 碌s (88.41%) |
| Adapter::Magic (Rust) | 馃搱 view plot 馃毞 view threshold | 26.74 碌s(-0.76%)Baseline: 26.94 碌s | 30.13 碌s (88.76%) |
| Adapter::Rust | 馃搱 view plot 馃毞 view threshold | 4.68 碌s(+8.20%)Baseline: 4.32 碌s | 6.64 碌s (70.41%) |
| Adapter::RustBench | 馃搱 view plot 馃毞 view threshold | 4.66 碌s(+8.01%)Baseline: 4.32 碌s | 6.63 碌s (70.28%) |
epompeii
added this pull request to stack #1042
September 18, 2026 06:48
epompeii
marked this pull request as ready for review
September 18, 2026 06:48
epompeii
marked this pull request as draft
October 1, 2026 02:26
epompeii
force-pushed
the
u/ep/s3-r2/disaster-recovery
branch
from
October 1, 2026 05:10
46b029b to
84cc308
Compare
epompeii
marked this pull request as ready for review
October 1, 2026 05:42
The continuous replication section was named plus.litestream in code, with disaster_recovery only as a serde alias, while the docs named plus.disaster_recovery. Rename the type and field to the documented key and drop the alias. Also drop the unused sftp replica scheme, so the section reads scheme: file | s3, and fix the docs example, which showed a replicas array the code never accepted.
epompeii
marked this pull request as draft
October 3, 2026 19:02
epompeii
force-pushed
the
u/ep/s3-r2/disaster-recovery
branch
from
October 3, 2026 19:03
84cc308 to
afa562d
Compare
epompeii
marked this pull request as ready for review
October 4, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The continuous replication section of the server config was named
plus.litestreamin code, withdisaster_recoveryaccepted only as a serde alias, while the docs have always named itplus.disaster_recovery. This makes the documented key the only key, drops the unusedsftpreplica scheme, and fixes the docs example, which showed areplicasarray the code never accepted and did not parse as JSON.Changes
JsonPlus.litestreambecomesdisaster_recovery: Option<JsonDisasterRecovery>; the alias is gone. The code that runs the Litestream binary keeps its Litestream names, since that is the vendor it drives.JsonReplica::Sftpand its YAML mapping are removed, so the section readsscheme: file | s3.sftpscheme; the shared config example shows a singlereplicaand loses the trailing comma afterloggingthat kept it from parsing.disaster_recoverydeserializes, that ansftpreplica fails with an unknown variant error, and that a leftoverlitestreamkey is ignored.Breaking changes
plus.litestreamis ignored, so disaster recovery does not run at all: no restore at startup and no replication. Rename the key toplus.disaster_recovery.sftpreplica scheme is removed.fileands3remain. A config that still usessftpfails to load.First of a stack of three: this, then removing the on demand backup endpoint, then moving the container registry storage onto
object_storewith the samescheme: file | s3config shape.