Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
Summary
Adds
@octokit/plugin-retryand@octokit/plugin-throttlingto the Octokit client, so transient errors and rate limits no longer fail the action. Dispatch is not retried after server or network errors, which avoids duplicate runs. Status polling keeps going through transient errors untilwait-timeout-seconds.Changes
src/octokit-client.ts(new)createOctokit()adds both official plugins togithub.getOctokit:NO_RETRY_REQUEST_OPTIONSturns off plugin-retry for one request. Rate limits on that request are still retried by the throttling plugin.isTransientError()uses the same rule as plugin-retry to decide whether an error is transient.src/wait-for-run.ts(new)run(). The clock, sleep and logger can be injected, so the loop can be tested.src/main.tsNO_RETRY_REQUEST_OPTIONS.waitForRunCompletion().fetch. Covered:typecheckandtestscripts, and@types/node.dependencies.tsconfig:noEmitandallowImportingTsExtensions; test files are now typechecked.dist/index.jsrebuilt.Behaviour changes
retry-afteror the reset time, up to 3×, with a warningwait-timeout-seconds