Repository navigation
Collect WeakMap entries with ephemeron semantics - #582
Open
jluxenberg wants to merge 2 commits into
Open
jluxenberg wants to merge 2 commits into
jluxenberg wants to merge 2 commits into
Conversation
WeakMap values were marked as reachable during gc_scan() regardless of whether their key was reachable, and entries were only removed once their key's refcount reached zero before a GC pass. As a result, an entry whose value references its own key was never collected, and a chain of N entries (each value referencing the next key) needed N GC passes to be freed. gc_scan() now only keeps a weak map value once its key has been found live, continuing the scan until no new object is kept. The reference to the values that are not kept is dropped so that they are freed with the cycles; the records are removed by the next GC as their key is no longer live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checks that a WeakMap entry whose value references its own key, and a chain of entries where each value references the next key, are freed by a single GC, and that the value of a live key is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581