Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6993 +/- ##
==========================================
+ Coverage 77.19% 77.20% +0.01%
==========================================
Files 163 163
Lines 21789 21813 +24
Branches 3360 3366 +6
==========================================
+ Hits 16820 16841 +21
- Misses 4149 4151 +2
- Partials 820 821 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reimporting a library file through a symlinked parent could treat the same file as a duplicate because its stored and imported paths used different spellings. Choosing Remove then deleted the original file.
Fixes #6930.
Why
The importer now recognizes an existing in-library file by physical identity when its exact stored path is not found. Reimport replacement and in-library moves use the same resolved containment check, so the file stays in the library while its metadata is refreshed.
Verification
uv run pytest test/test_importer.py::ReimportTest::test_reimported_album_through_symlink_preserves_file -qfailed because the reimport created a second file.uv run pytest test/test_importer.py -k 'ReimportTest or TestImportDuplicateAlbum or TestImportDuplicateSingleton' -qpasses with 32 passed and 2 skipped.To Do
Documentation. (No user-facing option or configuration change.)Changelog. (Bug fix only; no new user-facing behavior.)