Skip to content

Preserve exception tracebacks in Beeper JSON logs #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iFixRobots merged 2 commits into from
Oct 1, 2026
Merged

Preserve exception tracebacks in Beeper JSON logs #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d05c41b
Preserve exception tracebacks in Beeper JSON logs
iFixRobots Sep 28, 2026
5c76d43
Normalize branch slashes in CI image tags
iFixRobots Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/beeper-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ jobs:
tag=$(cat pyproject.toml | grep -E "^version =" | sed -E 's/^version = "(.+)"$/\1/')
else
tag="${{ github.head_ref || github.ref_name }}"
tag="${tag//\//-}"
fi

docker buildx build \
Expand Down
2 changes: 2 additions & 0 deletions synapse/logging/_terse_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,7 @@ def format(self, record: logging.LogRecord) -> str:
"level": record.levelname.lower(),
"time": round(record.created, 2),
}
if record.exc_info and record.exc_info[0]:
event["exc_traceback"] = self.formatException(record.exc_info)

@indent indent Bot Sep 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪️ Nit · No test for the new exc_traceback field

JsonFormatter and GcpJsonFormatter both have exception tests (test_with_exception, test_gcp_json_with_exception), but nothing tests BeeperTerseJsonFormatter. I ran the formatter by hand and it works: chained traceback present, one line per record, nothing emitted for exc_info=True with no active exception. A test would keep that behavior from regressing when upstream changes to JsonFormatter._format get merged in.


return self._format(record, event)
Loading