Skip to content

PLAT-39404 connector: unhide hidden chats when a new message arrives - #16

Merged
Fizzadar merged 2 commits into
mainfrom
nick/plat-39404-unhide-on-new-message
Oct 29, 2026
Merged

Fizzadar merged 2 commits into
mainfrom
nick/plat-39404-unhide-on-new-message

Conversation

@Fizzadar

Copy link
Copy Markdown
Contributor

Reddit hides a chat only "until someone sends another message" (its own hide dialog), but the bridge skipped every update for a hidden room until the chat was reopened natively, so new replies never reached Beeper. A message in an incremental sync now clears Reddit's hidden flag, as the native client does, and the room is handled normally, so the portal is recreated and the message backfilled. Full syncs don't unhide, since their timelines are history.

🤖 Generated with Claude Code

Reddit keeps a chat hidden only until someone sends another message, but the
bridge skipped hidden rooms until the chat was reopened natively.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@indent

indent Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Issues

All clear! No issues remaining. 🎉

1 issue already resolved
  • When one incremental sync batch contains both a hide for a room and a message in its timeline, the new code immediately un-hides the chat on Reddit and recreates the portal. This reverts a hide the user just made natively. Skip rooms hidden in the same batch. (fixed by commit ca9266c)
    Found by Indent Review Agent

CI Checks

All CI checks passed on ca9266c.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found in the current revision
Full results

Indent Review Agent

  • Summary: No issues found in the current revision
  • Last ran on commit: ca9266cd
  • Latest result
    {
      "summary": "No issues found in the current revision",
      "findings": []
    }

Comment thread pkg/connector/chatsync.go Outdated
… on a rejected unhide

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Fizzadar

Copy link
Copy Markdown
Contributor Author

Live-tested twice on a self-hosted bridge with real Reddit accounts, the second time at this head (ca9266c, in build 7990356 = main fbd38b0 + #16 + #17 + #18): hiding a test DM natively removed the portal and set hidden:true; a restart alone kept it hidden; the next message from the other side set hidden:false on Reddit (PUT 200), recreated the portal with the user joined, delivered the messages (including one sent while hidden) exactly once, and the chat reappeared in the native chat list. Still joined with no duplicates after another restart.

@Fizzadar
Fizzadar merged commit 8c8640f into main Oct 29, 2026
11 checks passed
@Fizzadar
Fizzadar deleted the nick/plat-39404-unhide-on-new-message branch October 29, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant