Repository navigation
PLAT-39442 connector: declare the reactions Reddit accepts - #14
Merged
Merged
Conversation
Reddit only takes its own reactions, but rooms didn't say which, so clients offered emoji the bridge then rejected. Skin-toned variants of aliased emoji now resolve too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Live-tested on a self-hosted bridge (build dbba83e = main ce81b9c + #14 at 0144af7 + #15) with real Reddit accounts:
Known client gap: Android's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reddit only accepts its own reactions, but rooms didn't advertise which, so clients offered emoji like ❤️ and 🎉 that the bridge then rejected. Room features now list the 32 emoji that map to Reddit reactions (capabilities v12, so existing rooms get the update), and skin-toned variants such as 👍🏼 resolve to the base reaction. Desktop and Android show a bounded picker when the list is set, so Reddit's 14 reactions without an emoji alias can only be added by tapping an existing one.
🤖 Generated with Claude Code