Skip to content

Match bridgev2's new GetChatInfoChange signature - #11

Closed
iFixRobots wants to merge 1 commit into
mainfrom
iFixRobots/chat-info-change-portal
Closed

iFixRobots wants to merge 1 commit into
mainfrom
iFixRobots/chat-info-change-portal

Conversation

@iFixRobots

Copy link
Copy Markdown
Contributor

megabridge's Update Bridges job has failed on every run since 21:08 UTC. It stops at Reddit:

pkg/connector/blocking.go:122:39: *blockListChange does not implement bridgev2.RemoteChatInfoChange (wrong type for method GetChatInfoChange)
    have GetChatInfoChange(context.Context) (*bridgev2.ChatInfoChange, error)
    want GetChatInfoChange(context.Context, *bridgev2.Portal) (*bridgev2.ChatInfoChange, error)

#4 added blockListChange with the old signature, but mautrix-go main now passes the portal. Every other bridge in megabridge already compiles against the new signature. Because the job builds every bridge together, no bridge can get new upstream commits until this compiles.

This PR updates the method signature, moves maunium.net/go/mautrix to current main so the repo builds standalone, and passes nil for the portal in the existing test call. The method doesn't use the portal, so behavior is unchanged.

go build ./..., go vet ./... and go test ./pkg/connector/ pass.

View in Indent
Tag @indent to continue the conversation here.

@indent indent Bot added the tested label Oct 27, 2026
@indent

indent Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Issues

No issues found.

CI Checks

All CI checks passed on f2d4d2f.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found; signature matches upstream.
Full results

Indent Review Agent

  • Summary: No issues found; signature matches upstream.
  • Last ran on commit: f2d4d2fb
  • Latest result
    {
      "summary": "No issues found; signature matches upstream.",
      "findings": []
    }

@indent

indent Bot commented Oct 27, 2026

Copy link
Copy Markdown

Superseded by #10.

@indent indent Bot closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant