Repository navigation
Match bridgev2's new GetChatInfoChange signature - #11
Closed
iFixRobots wants to merge 1 commit into
Closed
iFixRobots wants to merge 1 commit into
iFixRobots wants to merge 1 commit into
Conversation
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Superseded by #10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
megabridge's Update Bridges job has failed on every run since 21:08 UTC. It stops at Reddit:
#4 added
blockListChangewith the old signature, but mautrix-gomainnow passes the portal. Every other bridge in megabridge already compiles against the new signature. Because the job builds every bridge together, no bridge can get new upstream commits until this compiles.This PR updates the method signature, moves
maunium.net/go/mautrixto currentmainso the repo builds standalone, and passesnilfor the portal in the existing test call. The method doesn't use the portal, so behavior is unchanged.go build ./...,go vet ./...andgo test ./pkg/connector/pass.Tag
@indentto continue the conversation here.