Repository navigation
Bundle mhchem and move default props to parameters - #3
Merged
Merged
Conversation
React 19 drops defaultProps on function components, so throwOnError was undefined and KaTeX threw on any invalid expression; the WebView then printed the raw "Uncaught ParseError". Defaults now live in the parameter list (same fix as upstream 3axap4eHko#19). The inlined script also loads KaTeX's mhchem extension so \ce and \pu render, matching what the MathLive editor accepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19 ignores
defaultPropson function components, sothrowOnErrorreached KaTeX asundefined(KaTeX default:true). Any invalid expression threw and the WebView'swindow.onerrorprinted the raw "Uncaught ParseError". Defaults now live in the parameter list, same fix as upstream 3axap4eHko#19.The inlined script also loads KaTeX's
mhchemextension (same KaTeX version), so\ce{…}and\pu{…}render like they do in the MathLive editor.