Cleanup/misc cleanup Suggested by David - #122
Open
ounsworth wants to merge 4 commits into
Open
Conversation
ounsworth
marked this pull request as draft
September 9, 2026 04:44
…YLE.md as required reading in a way that allows us to update those without needing to change CLAUDE.md.
…3 crate. This commit was complicated by the fact that SM3 is present on this branch, despite its PR bcgit#89 still being open and not-yet-reviewed, so I decided that it was easier / cleaner to manually delete all of SM3 from this commit rather than refactor it also (since that would basically have become a review of SM3).
ounsworth
force-pushed
the
cleanup/misc_cleanup_from_david
branch
from
September 9, 2026 16:01
df3b166 to
bfe70b6
Compare
ounsworth
marked this pull request as ready for review
September 9, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
closes #104
Summary
The existing SHA2 / SHA3 primitives are exposed at the root of the crate as:
bouncycastle_sha2::{SHA224, SHA256, ..,}
I have now put the hmac and hkdf primitives in sub-mods so as not to clutter the roots of the crates' namespaces.
bouncycastle_sha2::hmac::{HMAC_SHA224, HMAC_SHA256, ..,}
bouncycastle_sha2::hkdf::{HKDF_SHA256, HKDF_SHA512, ..,}
bouncycastle_sha3::hmac::{HMAC_SHA3_224, HMAC_SHA3_256, ..,}
rebase this on top of the current (rolled back) release/0.1.3alpha. Probably the easiest way will be to make a new clean branch and merge in each commit one-by-one.
Scope and Risk
Flips the cargo.toml dependency order so that sha2 / sha3 are the user-facing crates, and hmac / hkdf are utility crates. This could affect some packaging stuff that depends on this.
Validation
Tests and docs updated to match. I manually edited through the doc updates.
AI Usage Statement
Did you use AI in creating this pull request:
Assisted-by: Claude Code:claude-opus-5