Added docs to SHA2 and SHA3 about cloning mid-stream - #121
Open
ounsworth wants to merge 20 commits into
Open
Conversation
… their HMAC variants
bcgit#95 not already on this branch
… and CLI wiring (PR bcgit#89)
… bits in the MSBs, unused low bits ignored
…ke the other hashes
…ptor with multi-block and one-shot methods (PR bcgit#107)
…-free bit-sliced AES permutation (PR bcgit#105)
…nd aes*-cbc CLI subcommands (PR bcgit#106)
…ryptor/PaddedDecryptor) (PR bcgit#97)
…me lengths, AES_CBC_* aliases, simpler CLI (PR bcgit#109)
…mmands and shared block-mode CLI (PR bcgit#111)
…locks8, SymmetricCipherEncryptor/Decryptor (from feature/sm4); CFB follows suit
…cb CLI subcommands; block-mode CLI generic over INIT_DATA_LEN
…S_PADS; SymmetricCipherEncryptor::do_final reports its output length
…with API changes and per-commit summaries
…rams/HashMLDSAParams/MLKEMParams traits, one impl per parameter set (bcgit#117)
hubot
force-pushed
the
release/0.1.3alpha
branch
from
September 9, 2026 01:44
d2a9b35 to
d1dcf75
Compare
Contributor
|
Okay, so it looked fine when I looked at it earlier, but it looks like it's based on the old release/0.1.3alpha tip, so it's picked up the extra commits. It'll need to be re-based back to the current 0.1.3alpha tip. To be honest, I recommend re-basing it off #113 or #115, it will probably be easier and likely give a cleaner result. Once the re-basing is done, this can be considered approved. |
dghgit
requested changes
Sep 9, 2026
dghgit
left a comment
dghgit
left a comment
Contributor
There was a problem hiding this comment.
It's been affected by the re-base. See comment at bottom of discussion page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds docs for cloning a hash function mid-stream so that you now have two hash objects that are identical up to this point, but you can feed different suffix input into before finalizing.
I put this next to the existing sections for
[Suspendable], since it's closely-related functionality. (and re-arranged order to put these before Memory Usage and Security Consideration sections).