fix: Regression: Use Modulus and Exponent for RSA Hash Codes - #708
Open
bb-froggy wants to merge 1 commit into
Open
fix: Regression: Use Modulus and Exponent for RSA Hash Codes#708bb-froggy wants to merge 1 commit into
bb-froggy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before BC 2.7.0, GetHashCode of RsaKeyParameters XORed the modulus and the exponent of the key as well as whether it was private.
With 8ee5212, this changed to XORing the modulus with itself (always resulting in 0) and so the value of GetHashCode() just depends on whether the key is private, but not on the actual parameters.
Describe your changes
This fix reverts to the previous behavior, where GetHashCode XORs modulus, exponent, and whether the key is private.
How has this been tested?
I haven't actually tested it.
Checklist before requesting a review
See also Contributing Guidelines.