Skip to content

fix: make session-close's mode-2 closer a combinable menu - #329

Merged
bborbe merged 2 commits into
masterfrom
feat/pick-any-closer
Oct 20, 2026
Merged

bborbe merged 2 commits into
masterfrom
feat/pick-any-closer

Conversation

@bborbe

@bborbe bborbe commented Oct 20, 2026

Copy link
Copy Markdown
Owner

What

session-close's mode-2 closer becomes a combinable menu: pick any — 1. /vault-cli:reflect · 2. /coding:self-improve · 3. review the runbook gap · 4. nothing — close.

The options were never alternatives — a session that wants both the reflection and the self-improvement runs both — but the closer emitted pick —, and a closer reaches the attention board with no tool_input at all, so the card declared no cardinality and rendered as radios with "(pick one)". The operator could answer "1 + 2" in the console and not on the board.

How

  • commands/session-close.md — the mode-2 closer line and the two sentences that describe it. nothing — close stays last; the combinable form makes it exclusive, so selecting it clears the other picks and any pick clears it.

Pieces this depends on

Repo What State
bborbe/claude the Stop hook parses pick any —, declares multiple, marks the last option exclusive PR #134
bborbe/attention-controller the exclusive field and the board rule that clears the other boxes v0.61.0, merged; deploy pending

An older board ignores the unknown exclusive field and renders the escape as an ordinary checkbox — it does not reject the card — so this is safe to merge before the deploy, and only the checkbox rendering waits on it.

Testing

Markdown only, no Go change. No test in the repo asserts the closer line (grep -rn "nothing — close" finds only CHANGELOG history).

@bborbe
bborbe marked this pull request as ready for review October 20, 2026 15:18

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
  "verdict": "approve",
  "summary": "Docs-only change: `commands/session-close.md` updates the mode-2 closer verb from `pick —` to `pick any —` with an explanation that this renders as checkboxes on the board rather than radios, allowing operators to select multiple follow-up actions. `CHANGELOG.md` records the unreleased change. No code changed.",
  "comments": [],
  "concerns_addressed": []
}

@ben-s-pull-request-reviewer
ben-s-pull-request-reviewer Bot dismissed their stale review October 20, 2026 15:31

superseded by new automated review

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my analysis of the 3 changed files in this PR:

  1. CHANGELOG.md - Accurately describes the fix: mode-2 closer changed from pick — to pick any — to enable combinable checkboxes on the attention board.

  2. commands/session-close.md - The closer at line 788 correctly reads 👤 You: pick any — 1. /vault-cli:reflect · 2. /coding:self-improve · 3. review the runbook gap · 4. nothing — close

  3. scripts/mode-membership-rule-test.sh - The MODE2_CLOSER constant at line 72 correctly expects 👤 You: pick any —

The test script (mode-membership-rule-test.sh) validates the prose rule that all three advisory signals (reflect, self-improve, runbook-improvement) must appear consistently on five surfaces: mode-1 header, mode-2 header, mode-2 closer, mode-2 body, and mode-3 advisory tail. This PR changes only the mode-2 closer surface from pick — to pick any —.

Scope: This is a docs-only change — no Go code was modified, as the PR description states. The concern about "no Go code references the old format" is addressed by the changelog note "commands/session-close.md only — no Go change."

{
  "verdict": "approve",
  "summary": "Docs-only change: the mode-2 closer in session-close.md is correctly updated to `pick any —` for combinable attention-board rendering, with consistent CHANGELOG entry and test script alignment.",
  "comments": [],
  "concerns_addressed": [
    {
      "concern": "correctness: MODE2_CLOSER expected string updated to match new format - verify test passes",
      "disposition": "addressed",
      "detail": "scripts/mode-membership-rule-test.sh:72 correctly expects '👤 You: pick any —' matching the session-close.md closer"
    },
    {
      "concern": "correctness: no Go code references the old 'pick —' format that would break",
      "disposition": "addressed",
      "detail": "PR description states and CHANGELOG confirms 'commands/session-close.md only — no Go change'; no Go files in diff"
    }
  ]
}

@bborbe
bborbe merged commit c3b4080 into master Oct 20, 2026
3 checks passed
@bborbe
bborbe deleted the feat/pick-any-closer branch October 20, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant