Remove supports-path-mapping from CppLink by default - #804
Open
keith wants to merge 1 commit into
Open
Conversation
There are 2 major known issues with this today: 1. When targeting macOS the debug info paths stored in the binaries are invalid, since they encode the literal `bazel-out/cfg` 2. Paths in environment variables configured in the toolchain are not path mapped today. They should be in a future bazel release, but the current fix will also only fix direct File objects not more complex cases If users are ok with these 2 limitations they should enable this manually with `--modify_execution_info=CppLink=+supports-path-mapping`
Collaborator
Collaborator
|
I realized I need to put this behind a feature flag anyway (there's a specific test target type we have issues with); I'll have a change out for review this week; if you're ok waiting. |
Member
Author
|
yea i think it's fine as long as we make it for the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 major known issues with this today:
invalid, since they encode the literal
bazel-out/cfgpath mapped today. They should be in a future bazel release, but the
current fix will also only fix direct File objects not more complex
cases
If users are ok with these 2 limitations they should enable this
manually with
--modify_execution_info=CppLink=+supports-path-mapping