Fix system_include_paths with textual_hdrs/hdrs and strip_include_prefix - #800
Open
keith wants to merge 2 commits into
Open
Fix system_include_paths with textual_hdrs/hdrs and strip_include_prefix#800keith wants to merge 2 commits into
keith wants to merge 2 commits into
Conversation
trybka
previously approved these changes
Jul 20, 2026
eric-wieser
reviewed
Jul 20, 2026
Comment on lines
496
to
500
| if public_headers.virtual_include_path: | ||
| if external: | ||
| external_include_dirs.append(public_headers.virtual_include_path) | ||
| else: | ||
| include_dirs_for_context.append(public_headers.virtual_include_path) |
There was a problem hiding this comment.
If it is deliberate that this does not match, could you add a comment as to why?
Member
Author
There was a problem hiding this comment.
nice spot, i added it on this one too
There was a problem hiding this comment.
FWIW I suggested this same change internally on friday (though without the tests you wrote), and am working through some internal build failures.
Member
Author
There was a problem hiding this comment.
ah cool. if that lands I can rebase for just the tests
keith
changed the title
trybka
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #537