chore: reorder if clauses in _init_cc_compilation_context - #799
Open
eric-wieser wants to merge 1 commit into
Open
chore: reorder if clauses in _init_cc_compilation_context#799eric-wieser wants to merge 1 commit into
if clauses in _init_cc_compilation_context#799eric-wieser wants to merge 1 commit into
Conversation
This makes them more closely resemble the `if`s` below. The logic is unchanged.
eric-wieser
commented
Jul 20, 2026
Comment on lines
517
to
520
| if external or feature_configuration.is_requested("system_include_paths"): | ||
| external_include_dirs.append(textual_headers.virtual_include_path) | ||
| else: | ||
| include_dirs_for_context.append(textual_headers.virtual_include_path) |
Author
There was a problem hiding this comment.
This is the logic the new order is closer to mirroring.
keith
approved these changes
Jul 20, 2026
trybka
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes them more closely resemble the
ifs below in the same file. The logic is unchanged.