Enable set_soname by default - #797
Open
keith wants to merge 3 commits into
Open
Conversation
This was already the case for macOS, and doesn't always matter for Linux, but when it does, this being not set is always wrong. If users are overwriting this today with linkopts or post processing, this shouldn't affect them.
Member
Author
|
the test revealed there is 1 issue with this. previously if you built the lib and copied it elsewhere and renamed it, if you manually dlopened it, things would be fine, but now that can fail if the name doesn't match. I still think this is the better default but that does mean there is more chance for breakage. luckily users doing |
fmeum
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already the case for macOS, and doesn't always matter for
Linux, but when it does, this being not set is always wrong. If users
are overwriting this today with linkopts or post processing, this
shouldn't affect them.