Expand tree artifacts in textual_hdrs in generated module maps - #787
Open
fmeum wants to merge 1 commit into
Open
Expand tree artifacts in textual_hdrs in generated module maps#787fmeum wants to merge 1 commit into
fmeum wants to merge 1 commit into
Conversation
Tree artifacts in a cc_library's textual_hdrs ended up in the generated
module map as a single header entry with the directory's path, which
fails to parse ('header ... not found'), instead of one textual header
entry per contained file like for hdrs and srcs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree artifacts in a
cc_library'stextual_hdrsend up in the generated module map as a singleheaderentry with the directory's path, which fails to parse (error: header '<dir path>' not found), instead of onetextual headerentry per contained file.hdrsandsrcsalready expand tree artifacts via the module map action's tree expander; this applies the same expansion to thepublic_textual_headersbucket.