android_binary: Omit output_jar_creator to prevent MANIFEST.MF clash … - #543
Open
06393993 wants to merge 1 commit into
Open
android_binary: Omit output_jar_creator to prevent MANIFEST.MF clash …#54306393993 wants to merge 1 commit into
06393993 wants to merge 1 commit into
Conversation
…in Android App Bundles Passing output_jar_creator = "bazel" during base APK packaging causes SingleJar to write "Created-By: bazel" (44 bytes) into base/root/META-INF/MANIFEST.MF. However, feature module packaging (_process_feature_module) invokes SingleJar without output_jar_creator, defaulting to "Created-By: singlejar" (48 bytes) for feature/root/META-INF/MANIFEST.MF. When Bundletool validates duplicate entries across module ZIPs, this SHA-256 content mismatch triggers an InvalidBundleException: "Modules 'base' and 'feature1' contain entry 'root/META-INF/MANIFEST.MF' with different content." Omitting output_jar_creator in android_binary allows SingleJar to use its default "singlejar" creator string for both base and feature modules, ensuring identical MANIFEST.MF contents and enabling successful bundle creation. Change-Id: I99089f1ee441ba3d418d619dffcfe6a26a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in Android App Bundles
Passing output_jar_creator = "bazel" during base APK packaging causes SingleJar to write "Created-By: bazel" (44 bytes) into base/root/META-INF/MANIFEST.MF.
However, feature module packaging (_process_feature_module) invokes SingleJar without output_jar_creator, defaulting to "Created-By: singlejar" (48 bytes) for feature/root/META-INF/MANIFEST.MF.
When Bundletool validates duplicate entries across module ZIPs, this SHA-256 content mismatch triggers an InvalidBundleException: "Modules 'base' and 'feature1' contain entry 'root/META-INF/MANIFEST.MF' with different content."
Omitting output_jar_creator in android_binary allows SingleJar to use its default "singlejar" creator string for both base and feature modules, ensuring identical MANIFEST.MF contents and enabling successful bundle creation.
Change-Id: I99089f1ee441ba3d418d619dffcfe6a26a6a6964