Repository navigation
build(release): build all release deliverables in presubmit - #4281
Merged
rickeylev merged 2 commits intoOct 19, 2026
Merged
Conversation
Release workflow bugs previously went unnoticed until cutting a release because artifact creation was coupled with publishing. Move runfiles wheel building, archive/notes generation, and artifact packaging into `release_build_artifacts.yaml` with `contents: read` permissions, trigger it on `pull_request`, and have `release_publish.yaml` download and publish the built artifacts.
…ert RELEASING.md Git < 2.35 (on Debian 11 and Ubuntu 22.04) does not support the :tags=true option in %(describe:tags=true). Always assert _COMMIT_PRIVATE expansion across all Git versions and only check _VERSION_PRIVATE when supported by the host git. Also revert unneeded presubmit notes from RELEASING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release workflow bugs previously went unnoticed until cutting a release
because artifact creation was coupled with publishing.
Move runfiles wheel building, archive/notes generation, and artifact
packaging into
release_build_artifacts.yamlwithcontents: readpermissions, trigger it on
pull_request, and haverelease_publish.yamldownload and publish the built artifacts.