Repository navigation
agents: document test construct comments and rule domain separation - #4255
Merged
rickeylev merged 1 commit intoOct 13, 2026
Merged
Conversation
Add guidance to testing.md to comment non-obvious test constructs (such as single-branch select() expressions used to test macro select() handling), and document model_decision vs glob triggers and domain separation in rule-creator/SKILL.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document inline comment expectations for non-obvious test constructs and
clarify rule trigger selection and domain separation.
Unusual test constructs (such as single-branch
select()expressionsused to exercise macro
select()handling) appear accidental without anexplanatory comment. Similarly, general domain rule files
(
starlark.md,bzl.md,python.md,docs.md) should remain separatefrom
rules_python-specific invariants (rules_python.md).Update
testing.mdto require inline comments on non-obvious testconstructs, and update
rule-creator/SKILL.mdto documentmodel_decisionvsglobtriggers and rule domain separation.