You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review: the fix is correct (_copy_config_value deep-copies mappings, lists and tuples, so aliases are no longer shared). One test problem to fix before merge.
The new test_nested_mapping_aliases_are_isolated_across_layers was inserted in the middle of test_shared_mapping_alias_is_valid_but_recursive_alias_is_rejected_with_path. The recursive-alias with tempfile.TemporaryDirectory() block that belonged to the original test now sits at the end of the new test. Nothing fails, but the original test no longer checks what its name says, and the new test has an unrelated recursive-YAML assertion. Please move that block back to the original test.
Non-blocking: a tuple branch in _copy_config_value is untested (YAML won't produce tuples, so it only matters for programmatic callers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407. Copies nested configuration containers so shared YAML aliases cannot make unrelated effective values mutate together. Tests: tests/test_batteries_included_config.py.