Repository navigation
Ruby 3.4.12 - #501
Merged
Merged
Ruby 3.4.12#501
Conversation
Writebook ran Ruby 3.4.7, which lacks the Onigmo regexp fixes that Ruby 3.4.12 carries. Move `.ruby-version`, both Dockerfiles and the lockfile to 3.4.12 on the stock `ruby:3.4.12-slim` image, and bump `ruby/setup-ruby` to v1.334.0, the first release that installs 3.4.12. ref: https://www.ruby-lang.org/en/news/2026/10/23/regexp-fixes-for-gitlab-cves/
There was a problem hiding this comment.
🟢 Approved
The scoped version updates are consistent across development, containers, and CI, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates Writebook to Ruby 3.4.12 to incorporate the Onigmo regexp security fixes, keeping development, containers, and CI aligned.
Changes:
- Updates Ruby version declarations and lockfile metadata to 3.4.12.
- Updates all four CI references to the pinned
ruby/setup-rubyv1.334.0 release.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| Gemfile.lock | Records Ruby 3.4.12p148. |
| Dockerfile-export | Updates the export image to Ruby 3.4.12. |
| Dockerfile | Updates the application image to Ruby 3.4.12. |
| .ruby-version | Sets the project Ruby version to 3.4.12. |
| .github/workflows/ci.yml | Updates the pinned Ruby setup action across four jobs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ruby 3.4.12 carries Onigmo regexp fixes for four GitLab CVEs. Writebook runs 3.4.7.
Details
Set Ruby to 3.4.12 in
.ruby-version, theRUBY_VERSIONargument ofDockerfileandDockerfile-export, and theRUBY VERSIONofGemfile.lock. Both images build on the stockruby:3.4.12-slim.Bump
ruby/setup-rubyin CI from v1.321.0 to v1.334.0, the first release that installs 3.4.12.Additional information
Both Dockerfiles build locally on
linux/amd64, including the trusted-roots check from #500.