Fix stale comments in ensureDeleteConfirmable - #668
Merged
Conversation
The force-flag work merged in #654 at 7ea0be6, before two comment revisions landed on the feature branch. The historical paragraph now speaks of the old gate in the past tense, and the closing note says what actually happened to isNonInteractiveCommand: the delete path bypasses it — machineReadsThisOutput asks the narrower question — and it is left untouched for its other callers, not "read, never widened".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Pull request overview
Updates stale historical comments around delete confirmation logic; runtime behavior is unchanged.
Changes:
- Describes the former confirmation gate in past tense.
- Clarifies why
isNonInteractiveCommandis bypassed.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#654 merged at 7ea0be6, before two comment-only revisions landed on the feature branch. This applies just those 16 lines — no code changes.
isNonInteractiveCommandsaid "read, never widened", but the delete path no longer consults it at all: it is deliberately bypassed —machineReadsThisOutputasks the narrower question this needs — and left untouched for its other callers (missingArg,noChanges), where widening would move behavior across many commands.bin/cigreen.Summary by cubic
Fixes two stale comments in
ensureDeleteConfirmablethat were left behind when the force-flag work merged in #654. No code behavior changes; this is comment text only.isNonInteractiveCommandis deliberately bypassed—machineReadsThisOutputasks the narrower question—and left untouched for its other callers (missingArg,noChanges), not "read, never widened".Written for commit 27af253. Summary will update on new commits.