Skip to content

Bump golang.org/x/crypto past CVE-2026-56854 - #667

Merged
jeremy merged 1 commit into
mainfrom
bump-x-crypto
Aug 29, 2026
Merged

Bump golang.org/x/crypto past CVE-2026-56854#667
jeremy merged 1 commit into
mainfrom
bump-x-crypto

Conversation

@jeremy

@jeremy jeremy commented Aug 29, 2026

Copy link
Copy Markdown
Member

The Trivy Security Scan check has been red on main since af381b34 (before #665/#666): CVE-2026-56854 in the indirect golang.org/x/crypto v0.54.0, fixed upstream in v0.55.0. Both open PRs' reviewers flagged the unexplained red check; this bump owns it.

go get golang.org/x/crypto@v0.55.0 && go mod tidy, plus the nix vendorHash recompute. No direct-dependency or code changes.


Summary by cubic

Bumps the indirect golang.org/x/crypto from v0.54.0 to v0.55.0 to resolve CVE-2026-56854, which has been failing the Trivy security scan on main.

No behavior changes; the dependency is indirect and the nix vendor hash is recomputed to match.

Written for commit 8e28ef8. Summary will update on new commits.

Review in cubic

Trivy has been red on main since af381b3: CVE-2026-56854 in the
indirect golang.org/x/crypto v0.54.0, fixed in v0.55.0. Bump it and
recompute the nix vendorHash.
Copilot AI balanced review requested due to automatic review settings August 29, 2026 00:16
@jeremy

jeremy commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

@codex review

@github-actions github-actions Bot added the deps label Aug 29, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T00:18:36.358645Z 8e28ef8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 8e28ef8515

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the indirect golang.org/x/crypto dependency to the release fixing CVE-2026-56854.

Changes:

  • Bumps x/crypto from v0.54.0 to v0.55.0.
  • Refreshes module checksums and the Nix vendor hash.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
go.mod Updates the indirect dependency version.
go.sum Updates checksums for v0.55.0.
nix/package.nix Refreshes the Nix vendor hash.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jeremy
jeremy merged commit 91494a5 into main Aug 29, 2026
35 checks passed
@jeremy
jeremy deleted the bump-x-crypto branch August 29, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants