fix(fork): explicitly pin fork profile to base = "cobalt" (v2.0.x release branch) - #219
Merged
Merged
Conversation
base = true resolved to the base-anvil's DEFAULT_BASE_UPGRADE at build time. As of base-anvil PR #71, that default is Cobalt — which happens to be correct today — but relying on an implicit default is fragile. Pinning to "cobalt" makes the intent explicit and ensures a future DEFAULT_BASE_UPGRADE bump doesn't silently change test behavior. Mirrors the same fix applied to the frozen Beryl snapshot (beryl-harness-patch), where base = "beryl" is required. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude <noreply@anthropic.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
September 8, 2026 17:29
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
✅ Fork tests: all 725 passedbase/base is fully in sync with the base-std spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
[profile.fork] baseto"cobalt"on thereleases/v2.0.xsnapshot, explicitly, instead ofrelying on the implicit
base = truedefault.base = trueresolves to base-anvil'sDEFAULT_BASE_UPGRADEat build time. As of base-anvil PR #71that default is Cobalt — correct today — but relying on the implicit default means a future
DEFAULT_BASE_UPGRADEbump would silently change which precompile dispatch version this frozenbranch's fork tests run against, without any diff in base-std to explain why.
Context
Same fix pattern already applied to the frozen Beryl snapshot (
releases/v1.0.x, commit520d069,tagged
v1.0.1) after base-anvil's default moved on from Beryl to Cobalt. This closes the same gapfor the new Cobalt release branch before it ships, rather than waiting for a future default bump to
break it the same way.
Cherry-picked from
1d005bc(originally proposed againstmainin #217, closed unmerged — retargetinghere since the pin only matters for a frozen branch, not
main, which is meant to track whateverhardfork is currently in development).
Test plan