feat(b20): rename SEIZE_HOLDER_POLICY to SEIZE_EXEMPT_POLICY - #214
Merged
Conversation
Authorized accounts cannot be seized, so the scope name now states that polarity instead of sounding like a seizable-holder list. Co-authored-by: Cursor <cursoragent@cursor.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
September 2, 2026 13:39
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
8 tasks
|
stephancill
approved these changes
Sep 2, 2026
| | Bits | Lane | Field | Scope | | ||
| | ------- | ---- | ---------- | ----------------------- | | ||
| | 0–63 | 0 | `seizable` | `SEIZE_HOLDER_POLICY` | | ||
| | 0–63 | 0 | `seizable` | `SEIZE_EXEMPT_POLICY` | |
Collaborator
There was a problem hiding this comment.
Naming doesn't make sense between seizable and policy name
Collaborator
Author
There was a problem hiding this comment.
good catch, the packed struct filed seems to be not caught. Updated
|
|
||
| /// @notice Extracts the seize-holder policy id (lane 0) from the seize packed slot. | ||
| /// @notice Extracts the seize-exempt policy id (lane 0) from the seize packed slot. | ||
| function seizablePolicyId(uint256 packed) internal pure returns (uint64) { |
Collaborator
There was a problem hiding this comment.
Feels like cruft we should clean up when you have downtime. There are two policies under seize operation
Collaborator
Author
There was a problem hiding this comment.
Fixed now, later sometimes never comes hahah
The SEIZE_EXEMPT_POLICY lane and its accessors still used the pre-rename "seizable" name, which no longer matches the policy and reads backwards (exempt accounts are NOT seizable). Mirrors how the receiver lane already matches SEIZE_RECEIVER_POLICY. Addresses review comments on PR #214. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEIZE_HOLDER_POLICYtoSEIZE_EXEMPT_POLICYso the identifier matches the inverted check: authorized accounts are seize-exempt.IB20getter,B20Constantskeccak preimage, mocks, tests, smoke journey, and Cobalt changelog (selector0xfeb346ec, valuekeccak256("SEIZE_EXEMPT_POLICY")).SEIZE_HOLDER_POLICY()must not resolve;SEIZE_EXEMPT_POLICY()must match the new digest.This is a Cobalt wire change (the scope hash and getter selector both change). The Rust precompile in
base/baseneeds the same preimage before live-precompile tests can pass.Test plan
forge test(735 passed locally)forge fmt --checktoken.SEIZE_EXEMPT_POLICY() == keccak256("SEIZE_EXEMPT_POLICY")SEIZE_HOLDER_POLICY()no longer resolvesbase/basebeforebase-forge test/make fork-testsMade with Cursor