Repository navigation
Run the shop workflow on branch pushes only - #145
Merged
Merged
Conversation
A release tag push also matched the push trigger, so every release started a shop run per tag whose deploy-preview job failed: the shop-preview environment admits branches, not tags. The rc.12 release left five such red runs. CI already limits its push trigger this way. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Shop preview: https://bascik-shop-pr-145.collin-inbox.workers.dev Stripe sandbox payments are enabled. Paid orders create unconfirmed Printful drafts only. Production confirmation and customer email are blocked in test mode. No live domain changes. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Each release tag push also triggered the Shop workflow, because its
pushtrigger had nobranchesfilter. The shop validated fine, thendeploy-previewfailed without running a step: theshop-previewenvironment admits branches, not tags. The rc.12 release left five red Shop runs this way, one per tag.The
pushtrigger now hasbranches: ["**"], asci.ymlalready does, so tag pushes no longer start the workflow. Branch pushes, includingmain, and pull requests behave as before.Checklist
yarn check:formatpasses for the changed fileCHANGELOG.md: no entry, CI onlyValidation
shop/tests/workflows.test.tsandshop/tests/production.test.ts: 42 passedpkg/e2e/scripts/ci-deploy.test.ts: 74 passedpush.branchesset to**🤖 Generated with Claude Code