Repository navigation
feat(brand): use the Flagward mark in the nav, auth pages, favicon and app icons - #61
Merged
Merged
Conversation
Replaces the generic foreground square in the dashboard nav with /logo.png (decorative: empty alt so screen readers announce the brand name once), adds icon.png and apple-icon.png so Next serves the app icons, refreshes favicon.ico from the same mark, and removes the five unused Next.js template SVGs.
Centers /logo.png above the auth card on both pages. Same decorative-alt reasoning as the nav: each card title already reads Flagward, so the mark carries empty alt.
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The dashboard nav wore a generic foreground square with a flag glyph — a placeholder, not a brand. Now it wears the Flagward mark, and the auth pages do too.
dashboard-nav.tsxrenders/logo.pngvianext/image(priority,h-6 w-auto) instead of thebg-foregroundsquare. Thealtis deliberately empty: the link already reads as the brand name from the text beside it, so a labelled mark would have a screen reader announce the name twice.h-12). Same decorative-alt reasoning — each card title already reads "Flagward" (login.title,register.title), so the mark carries empty alt.src/app/icon.png(512) andsrc/app/apple-icon.png(180), so Next serves/icon.pngand/apple-icon.pngby file convention — the build output confirms both routes.favicon.icoregenerated from the same mark (25 KB → 5.7 KB, 16/32/48).file,globe,next,vercel,window) are gone; nothing referenced them..DS_Storeignored.frontend/brand/logo-source.png(the 1254px source the derivatives were cut from) stays out of the tree deliberately — it lives on disk if we need to re-cut, but this PR ships only what the product serves.How was it verified?
Backend is untouched; those two ran to confirm it. The SVG deletions were verified with a repo-wide grep for each filename before removal — zero references. The register suite passing with
next/imagein the tree confirms the mark renders without breaking the page's queries.Checklist
ruff check .passespytestpassesnpm run lintandnpm run buildpass, if the frontend changedTests box left unchecked deliberately: a logo placement has no behaviour to pin — asserting an
Imagesrcwould test implementation, not behaviour. Docs box unchecked: no documented behaviour changed.