Handle queued XRPL transactions before retrying - #92
Merged
Conversation
Marca23
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terQUEUEDsubmission to reach a validated result using its original transaction hashtxnNotFoundfollowed by validatedtesSUCCESSRoot Cause
Falcon treated every initial XRPL engine result other than
tesSUCCESSas a broadcast failure. However,terQUEUEDmeans the submitted transaction is pending and may still validate. Falcon immediately entered its normal retry loop, fetched a newer account sequence, and signed the same logical Oracle update again. When the original transaction subsequently validated, those later attempts produced sequence-related failures such astefPAST_SEQand repeated relay alerts.Scope
Validation
go test -timeout=2m ./relayer/chains/xrpl -count=1go test -timeout=2m ./relayer/chains/... -count=1go vet ./relayer/chains/xrplgolangci-lint run --timeout=5m0sgit diff --checkLimitation
The pending transaction is tracked in process until validation or service-context cancellation. Durable restart recovery and
LastLedgerSequenceexpiry handling are intentionally outside this minimal fix.