Skip to content

chore: update Ruff & BasedPyright - #656

Open
disrupted wants to merge 4 commits into
refactor-kafka-connectfrom
update-ruff
Open

chore: update Ruff & BasedPyright#656
disrupted wants to merge 4 commits into
refactor-kafka-connectfrom
update-ruff

Conversation

@disrupted

Copy link
Copy Markdown
Member

No description provided.

@disrupted
disrupted changed the base branch from main to refactor-kafka-connect July 29, 2026 12:09
@disrupted
disrupted marked this pull request as ready for review July 29, 2026 12:11
@tobbber
tobbber requested a review from Copilot July 29, 2026 12:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Python developer tooling (Ruff + BasedPyright) and applies small code/test refactors to satisfy new lint/type-check expectations while keeping runtime behavior consistent with the project’s Python 3.11+ baseline.

Changes:

  • Bump dev tool versions: basedpyright to >=1.39.9 and ruff to >=0.16.0 (plus lockfile refresh).
  • Refactor enums to use enum.StrEnum and apply minor code cleanups prompted by updated linting/type checking.
  • Adjust tests and Ruff config to align with updated lint rules (e.g., regex match strings, implicit string concatenation, lazy-import rule ignore in tests).

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Updates locked versions/artifacts for BasedPyright and Ruff.
pyproject.toml Bumps dev dependencies; adds Ruff per-file ignore for PLC0415 in tests.
kpops/utils/cli_commands.py Minor refactor in recursive field extraction (uses loop value directly).
kpops/manifests/argo.py Switches enum to enum.StrEnum.
kpops/core/operation.py Switches enum to enum.StrEnum.
kpops/core/registry.py Adds targeted Ruff suppression for lazy import in module discovery.
kpops/components/streams_bootstrap/base.py Marks unused regex groups with underscore-prefixed names.
kpops/components/common/kubernetes_model.py Switches multiple enums to enum.StrEnum.
kpops/component_handlers/kafka_connect/model.py Tweaks validator return type annotation ordering.
tests/conftest.py Makes cache clearing conditional on cache presence.
tests/utils/test_doc_gen.py Fixes string building/implicit concatenation in expected markdown output.
tests/test_kpops_config.py Uses raw regex string for pytest.raises(match=...).
tests/pipeline/test_generate.py Uses raw regex strings for pytest.raises(match=...).
tests/manifests/strimzi/test_kafka_topic.py Uses raw regex string for pytest.raises(match=...).
tests/component_handlers/topic/test_topic_handler.py Uses raw regex strings for pytest.raises(match=...).
tests/component_handlers/helm_wrapper/test_helm_wrapper.py Removes pyright ignore; uses raw regex strings; minor formatting.
tests/component_handlers/helm_wrapper/test_helm_diff.py Groups implicit string concatenation for log assertion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@disrupted
disrupted requested a review from tobbber July 29, 2026 13:17
@disrupted disrupted added the area/dependencies Relates to project dependencies label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Relates to project dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants