Repository navigation
fix: don't start counting the backup's rows when stopped while preparing the list - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #64. If the caller stops
countRowsInDumpwhile it is making the temp dir or writing theTABLE DATAlist, the abort event has already fired by the time the listener is attached, so thepg_restore --data-onlypass would start anyway and read the whole dump beforeverifyRestoredcould return.countRowsInDumpnow checks the signal again right before spawning. That check and attaching the listener happen in the same tick, so there's no gap left.Tests
test/drill-row-counts.test.js: a signal that reads as stopped as soon as the temp dir exists, withpg_restorewrapped to log every call. Returns null and the log has the--listcall but no--data-onlycall. Without the fix this assertion fails.npm teston 61d7cc8).No preview environment for the CLI; verified by the tests above. 2.11.0 isn't published yet, so no version bump.