fix(archiver): compare fee modifier when checking a checkpoint against L1 - #136
Merged
Merged
Conversation
labsbox
Bot
force-pushed
the
rk/fix-a1783-feemodifier-equivocation
branch
from
September 9, 2026 11:06
be726c3 to
42e078b
Compare
 The PR appears safe to merge, with the added comparison correctly routing modifier-only divergence through the existing equivocation recovery path.
|
spalladino
approved these changes
Sep 9, 2026
spalladino
left a comment
spalladino
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Can you add the feeAssetPriceModifier to the attributes logged in the log.warn below for debugging, and then merge?
rkarabut
enabled auto-merge (squash)
September 9, 2026 16:49
rkarabut
force-pushed
the
rk/fix-a1783-feemodifier-equivocation
branch
from
September 14, 2026 08:57
0215159 to
0ca7b90
Compare
…t L1 The L1-sync divergence check compared the header and archive root but not feeAssetPriceModifier, the third field the committee signs (it is not part of the header). A checkpoint differing only in the fee modifier was treated as identical, so the mismatch branch was skipped. Compare it too, so the check covers the full signed payload. Adds a regression test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…view nit) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rkarabut
force-pushed
the
rk/fix-a1783-feemodifier-equivocation
branch
from
September 15, 2026 08:40
0ca7b90 to
c506d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archiver decides whether a local checkpoint matches the one on L1 by comparing the header and the archive root, while the committee actually signs
feeAssetPriceModifieralong with them. The mismatch won't be detected if the fee modifier differs.I don't think this could be exploited in a meaningful way (besides for some purpose making previous committee signatures invalid) but for correctness we should check all the fields we sign on.