見分けにくい単独記号の変換候補に説明を表示する - #371
Open
sinoda1114 wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
Coreの自動annotation付与が既存annotationを尊重しつつ単独記号に限定され、UI側も表示幅・セル再利用・アクセシビリティをテスト込みで整合させています。
Pull request overview
単独の記号候補（- / － / ｰ / ー / −）が見分けにくい問題に対して、候補の文字や順序を変えずに「記号名（説明）」を付与して表示できるようにするPRです。Core側で説明文（annotation）を自動生成し、macOS UI側では表示幅計算とアクセシビリティラベルへ反映することで、視認性と読み上げの両方を改善しています。
Changes:
- Core: 単独記号の候補に対して annotation（例:
-→半角ハイフン）を自動付与（既存annotationがあれば優先） - Core/UI テスト: 説明生成のテストと、セル再利用時のクリア・アクセシビリティ・ウィンドウ幅計算のテストを追加
- ドキュメント: READMEに仕様（対象記号・既存説明優先・語中は対象外）を追記
File summaries
| File | Description |
|---|---|
| README.md | 単独記号候補に表示される説明の仕様を追記 |
| Core/Tests/CoreTests/InputUtilsTests/CandidateSymbolAnnotationTests.swift | Core側の説明付与仕様（単独限定・既存優先・transport保持）をテスト追加 |
| Core/Sources/Core/InputUtils/CandidatePresentationContext.swift | CandidatePresentation 初期化時に単独記号のannotationを自動生成 |
| azooKeyMacTests/CandidateSelectionFeedbackTests.swift | UI側のアクセシビリティ反映・セル再利用時のクリア・幅計算のテスト追加 |
| azooKeyMac/InputController/CandidateWindow/CandidateView.swift | アクセシビリティラベルの更新、annotation幅を考慮したウィンドウ幅計算へ更新 |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-・－・ｰ・ー・−の単独候補に記号名を表示します。候補の文字と順序を維持し、既存の説明を優先します。表示幅とアクセシビリティにも反映します。
検証
Coreの説明生成テストとUI側の候補表示テストを追加。追加したAppKitテストは未実行です。
このブランチ単独で
swift test --package-path Core --jobs 4を実行し、Coreの70テストが成功しました。git diff --checkも成功しています。