fix: 入力方式で「カスタム」を選んでも既定のローマ字入力のままになる問題を修正 - #360
Open
shiina-archelon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359
修正
カスタム入力テーブルの保存先を、sandbox の内外どちらからも見える App Group の共有コンテナに変える。
CustomInputTableStore.directoryURLをAppGroup.applicationSupportDirectoryURL()の下 (…/Group Containers/group.dev.ensan.inputmethod.azooKeyMac/Library/Application Support/azooKey/CustomInputTable/) にする。macOS 以外は従来のままConfigWindow.migrateLegacyCustomInputTableIfNeeded)。旧保存先の file は残す保存先の決め方とコピーの手順は、typo correction の重み (
ConfigWindow.migrateLegacyDebugTypoCorrectionWeightsIfNeeded) と同じ形にした。(ほぼ真似しました)こちらは既に App Group の共有コンテナに保存し、旧保存先に残っている重みを設定画面を開いたときにコピーしている。
確認
swift testpassswiftlint --strictpassr→す)