Skip to content

Ensure that worldbuffs are restricted from TBC Content and onwards. - #84

Merged
Nyeriah merged 1 commit into
azerothcore:masterfrom
TheSCREWEDSoftware:master
Oct 17, 2026
Merged

Nyeriah merged 1 commit into
azerothcore:masterfrom
TheSCREWEDSoftware:master

Conversation

@TheSCREWEDSoftware

@TheSCREWEDSoftware TheSCREWEDSoftware commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor
  • Ensure the table doesn't get dropped if it exists.
  • Only delete the IDs being applied (people could have custom maps, the previous statement would delete all).
  • Seperation and easier organisation for each catergory.

The existing entries were not changed, only one that was corrected the comment for "556" which said Forbid in Eye of the Storm but was Sethekk Halls.

TODO: Eventually move this table and part of the script into it's own module IMO

BGs

Vanilla

  • Alterac Valley
  • Warsong Gulch
  • Arathi Basin

TBC

  • Eye of the Storm

WotLK

  • Strand of the Ancients
  • Isle of Conquest

Arenas

TBC

  • Ring of Trials
  • Blade's Edge Arena
  • Ruins of Lordaeron

WotLK

  • Dalaran Arena
  • Ring of Valor

Raids

Vanilla

  • Molten Core
  • Onyxia's Lair
  • Blackwing Lair
  • Ruins of Ahn'Qiraj
  • Zul Gurub
  • Temple of Ahn'Qiraj

TBC

  • Karazhan
  • Gruul's Lair
  • Magtheridon's Lair
  • Serpentshrine Cavern
  • Tempest Keep
  • Battle for Mount Hyjal
  • Black Temple
  • Zul'Aman
  • Sunwell Plateau

WotLK

  • Naxxramas
  • The Obsidian Sanctum
  • The Eye of Eternity
  • Vault of Archavon
  • Ulduar
  • Trial of the Crusader
  • Icecrown Citadel
  • The Ruby Sanctum

Dungeons

Vanilla

  • Ragefire Chasm (commented out)
  • The Deadmines (commented out)
  • Wailing Caverns (commented out)
  • Shadowfang Keep (commented out)
  • Blackfathom Deeps (commented out)
  • The Stockade (commented out)
  • Gnomeregan (commented out)
  • Razorfen Kraul (commented out)
  • Scarlet Monastery (commented out)
  • Razorfen Downs (commented out)
  • Uldaman (commented out)
  • Zul'Farrak (commented out)
  • Maraudon (commented out)
  • Sunken Temple (commented out)
  • Blackrock Depths (commented out)
  • Blackrock Spire (commented out)
  • Dire Maul (commented out)
  • Scholomance (commented out)
  • Stratholme (commented out)

TBC

  • Hellfire Ramparts
  • The Blood Furnace
  • The Shattered Halls
  • The Slave Pens
  • The Underbog
  • The Steamvault
  • Mana-Tombs
  • Auchenai Crypts
  • Sethekk Halls
  • Shadow Labyrinth
  • Old Hillsbrad Foothills
  • The Black Morass
  • The Mechanar
  • The Botanica
  • The Arcatraz
  • Magisters' Terrace

WotLK

  • Utgarde Keep
  • The Nexus
  • Azjol-Nerub
  • Ahn'kahet: The Old Kingdom
  • Drak'Tharon Keep
  • The Violet Hold
  • Gundrak
  • Halls of Stone
  • Halls of Lightning
  • The Oculus
  • Utgarde Pinnacle
  • The Culling of Stratholme
  • Trial of the Champion
  • The Forge of Souls
  • Pit of Saron
  • Halls of Reflection

Summary by CodeRabbit

  • Bug Fixes
    • Updated disallowed-buff settings for battlegrounds, arenas, raids, and dungeons, including additional TBC and WotLK locations.
    • Corrected the Eye of the Storm map entry. Existing settings for unrelated maps are preserved.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f5a7214-58b8-4d40-a1e0-b5fa7a0edb78
📥 Commits

Reviewing files that changed from the base of the PR and between f644224 and 8ecc7af.

📒 Files selected for processing: 1
  • data/sql/db-world/zone_difficulty_disallowed_buffs.sql

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The SQL script conditionally creates zone_difficulty_disallowed_buffs, limits deletion to listed map IDs, and inserts disallowed-buff settings for battlegrounds, arenas, raids, and dungeons. The Eye of the Storm map ID changes from 556 to 566.

Changes: Disallowed Buff Map Data

Layer / File(s) Summary
Conditional table setup and scoped refresh
data/sql/db-world/zone_difficulty_disallowed_buffs.sql
The script creates the table only if it does not already exist. It deletes rows only for the listed map IDs.
Map disallowed-buff entries
data/sql/db-world/zone_difficulty_disallowed_buffs.sql
The insert data updates the Eye of the Storm map ID from 556 to 566 and adds entries for WotLK battlegrounds and raids, plus TBC and WotLK dungeons. Vanilla dungeon entries remain commented out.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: 55honey

Merge Risk: ⚪ Minimal · up to 8ecc7

The script preserves existing Vanilla dungeon settings and replaces the listed map settings. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and accurately summarizes the main change: restricting world buffs from TBC content and later expansions.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Nyeriah
Nyeriah merged commit fbd55bb into azerothcore:master Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants