Skip to content

feat(PlayerMethods): Expose RepopAtGraveyard - #394

Open
MacWarrior wants to merge 1 commit into
azerothcore:masterfrom
GmFactoryWoW:RepopAtGraveyard-master
Open

feat(PlayerMethods): Expose RepopAtGraveyard#394
MacWarrior wants to merge 1 commit into
azerothcore:masterfrom
GmFactoryWoW:RepopAtGraveyard-master

Conversation

@MacWarrior

@MacWarrior MacWarrior commented Aug 3, 2026

Copy link
Copy Markdown

Expose RepopAtGraveyard function to lua scripts

Summary by CodeRabbit

  • New Features
    • Added Lua scripting support for returning players to the most appropriate graveyard based on their corpse location.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7209f8b3-f1de-4f13-ae86-76af4f71df1d

📥 Commits

Reviewing files that changed from the base of the PR and between 9e5b8c6 and 384e9cb.

📒 Files selected for processing (2)
  • src/LuaEngine/LuaFunctions.cpp
  • src/LuaEngine/methods/PlayerMethods.h

📝 Walkthrough

Walkthrough

Changes

Player graveyard respawn

Layer / File(s) Summary
Register and implement graveyard respawn
src/LuaEngine/methods/PlayerMethods.h, src/LuaEngine/LuaFunctions.cpp
Adds LuaPlayer::RepopAtGraveyard and registers Player:RepopAtGraveyard in the Lua player method registry. The binding delegates to Player::RepopAtGraveyard().

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: aldori15

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes exposing Player::RepopAtGraveyard through Lua player methods.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant