Extract the rendered entity ID codec out of renderedEntities - #2126
Closed
kmcginnes wants to merge 1 commit into
Closed
Extract the rendered entity ID codec out of renderedEntities#2126kmcginnes wants to merge 1 commit into
kmcginnes wants to merge 1 commit into
Conversation
`renderedEntities.ts` had accumulated four unrelated concerns: a pure string ID codec, the canvas visibility atom, the style scope, and the Cytoscape render hooks. Only the last is what the module name describes. The codec has no coupling to the rest — no React, no Jotai, no state — and is exactly the unit the first four test blocks covered, so it moves out whole along with them. 263 lines down to 193.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
renderedEntities.tshad accumulated four unrelated concerns: a pure string ID codec, the canvas visibility atom, the style scope, and the cytoscape render hooks. Only the last is what the module name describes.The codec has no coupling to the rest — no React, no Jotai, no state — and was exactly the unit the first four test blocks covered, so it moves out whole along with them. 263 lines down to 193. Pure move: no behaviour, signature, or exported name changes, and the barrel keeps every symbol public at the same path.
No deep import paths needed updating; every consumer already imported through
@/core.How to read
renderedEntityIds.tsand its test are the moved code. The diff onrenderedEntities.tsis deletions plus one import.