Attribute empty expand results to active filters, not exhaustion - #2071
Open
mig-builds wants to merge 1 commit into
Open
Attribute empty expand results to active filters, not exhaustion#2071mig-builds wants to merge 1 commit into
mig-builds wants to merge 1 commit into
Conversation
…stead of claiming exhaustion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2060
What changed
useExpandNode's toast message after an empty expansion result no longer always says "No more neighbors to expand." That message is only accurate when no filters were applied. When the request carried non-emptyattributeFiltersand the result came back empty, the toast now says "No neighbors matched your filters" instead, since the node may still have neighbors that the filter excluded.Applied at both call sites (
expandNodefor a single node,expandNodesfor multiple), since the fix path in the issue noted the multi-node path could gain filter support later.Verification
expandNodeandexpandNodes.pnpm checks(lint, format, types) passes.pnpm testpasses except for one pre-existing, unrelated failure insafeSessionStorage.test.ts(confirmed it fails identically onmainwithout this change).