Add AddOrRemoveAllButton to BundleSearchResult - #2050
Open
TakshPatel5821 wants to merge 1 commit into
Open
Conversation
Adds a bulk add/remove button to bundle search results, matching the pattern used for individual vertex/edge results and the top-level "add all" button. Fixes aws#1221.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an "add all / remove all" button to bundle search results, so a bundle containing multiple graphable entities (vertices and/or edges, including nested bundles) can be added to or removed from the graph in one click, instead of adding each entity individually.
This follows the same pattern already used elsewhere in the search sidebar:
SearchResultsList's top-levelAddAllToGraphButton(bulk add/remove across all results)VertexSearchResult/EdgeSearchResult's per-entityAddOrRemoveButtonThe new
AddOrRemoveAllButton:getAllGraphableEntities(notgetAllGraphableEntityIds) sincebundle.valuesisPatchedResultEntity[], which has differententityTypevalues (patched-vertex/patched-edge) than the rawResultEntity[]the id-only helper expects.Validation
tsc --noEmitpasses with no errors.oxfmt --checkpasses on the changed file.connector/entities/entities.test.ts(coveringgetAllGraphableEntities) still pass.AddAllToGraphButton/AddOrRemoveButtonpatterns for consistency (icon-only ghost button,stopPropagationon click so it doesn't toggle the collapsible,size="icon-small", tooltip text).Related Issues
Fixes #1221