Skip to content

fix(sagemaker): Validate clusterId format in open-notebook extension #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aakashmandavilli96 wants to merge 1 commit into
base: 1.1
Choose a base branch
from
+12 −1
Open

fix(sagemaker): Validate clusterId format in open-notebook extension #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion patches/sagemaker/sagemaker-open-notebook-extension.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Index: code-editor-src/extensions/sagemaker-open-notebook-extension/src/extensio
===================================================================
--- /dev/null
+++ code-editor-src/extensions/sagemaker-open-notebook-extension/src/extension.ts
@@ -0,0 +1,100 @@
@@ -0,0 +1,111 @@
+
+import * as vscode from 'vscode';
+import * as https from 'https';
Expand All @@ -154,11 +154,22 @@ Index: code-editor-src/extensions/sagemaker-open-notebook-extension/src/extensio
+ return regionRegex.test(region);
+}
+
+function isValidClusterId(clusterId: string): boolean {
+ // Cluster IDs/names are alphanumeric with hyphens and underscores only
+ const clusterIdRegex = /^[a-zA-Z0-9_-]+$/;
+ return clusterIdRegex.test(clusterId);
+}
+
+async function loadAndDisplayNotebook(fileKey: string, clusterId: string, region: string) {
+ if (!isValidRegion(region)) {
+ vscode.window.showErrorMessage('Invalid region format. Region should only contain characters, numbers, and hyphens.');
+ return;
+ }
+
+ if (clusterId && !isValidClusterId(clusterId)) {
+ vscode.window.showErrorMessage('Invalid cluster ID format. Cluster ID should only contain letters, numbers, hyphens, and underscores.');
+ return;
+ }
+
+ const bucketName = `jumpstart-cache-prod-${region}`;
+ const url = `https://${bucketName}.s3.${region}.amazonaws.com/${fileKey}`;
Expand Down
Loading