Repository navigation
chore: declare ostruct as a test dependency - #3486
Merged
Merged
Conversation
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md. |
|
Detected 1 possible performance regressions:
|
dscpinheiro
approved these changes
Nov 3, 2026
jterapin
requested review from
richardwang1124
and removed request for
sankettangade and
sichanyoo
November 4, 2026 17:20
richardwang1124
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Context
Oj 3.17.8 removed its runtime dependency on
ostruct. SDK specs requireostruct, but the Gemfile does not declare it, causing Ruby 4.0 CI jobs to fail while loading the suite. Earlier runs passed because Oj 3.17.7 supplied the dependency.Description
ostructin the Gemfile's test group so the specs have their required dependency.Testing
ostructfixes it.🤖 This PR description was drafted with AI assistance for @jterapin. ✨