Skip to content

Fix login_session profile region resolution - #7202

Open
ford220102 wants to merge 1 commit into
aws:masterfrom
ford220102:agent/fix-login-session-profile-region
Open

Fix login_session profile region resolution#7202
ford220102 wants to merge 1 commit into
aws:masterfrom
ford220102:agent/fix-login-session-profile-region

Conversation

@ford220102

Copy link
Copy Markdown

Summary

Fixes the region resolution bug described in #7196.

LoginProfileCredentialsProviderFactory created SigninClient with SigninClient.create(), which uses the default region provider chain and can ignore the region configured in the active profile. This caused login_session credentials to use the wrong region or fail when only the named profile supplied a region.

The factory now builds the client explicitly and applies ProfileProperty.REGION when present. Profiles without a region retain the existing default provider-chain fallback.

Tests

  • LoginProfileCredentialsProviderFactoryTest: 3 tests passed
  • ./mvnw -pl services/signin -Daws.region=us-east-1 -Dtest=LoginProfileCredentialsProviderFactoryTest -Dsurefire.failIfNoSpecifiedTests=false test
  • git diff --check passed
  • Dependency reactor packaged and installed successfully with tests skipped and Javadocs skipped

@ford220102
ford220102 force-pushed the agent/fix-login-session-profile-region branch from c856fdb to d8bffcf Compare July 29, 2026 10:55
@ford220102
ford220102 marked this pull request as ready for review July 29, 2026 10:59
@ford220102
ford220102 requested a review from a team as a code owner July 29, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant